Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: initials function causing crash 🐞 #1350

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

luke-mcfarlane-rocketlab
Copy link
Contributor

JIRA Ticket

BSS-794

Description

Resolving the issue where having extra spacing in name would cause the app to crash.

Proposed Changes

  • updated initials function to index the substrings using slice to avoid crashing on empty strings

How to Test

  1. Create a new account with extra spacing in the name e.g " Luke Test "
  2. Log in to new conductor using that account
  3. Verify the app loads normally and your profile initials are displaying correctly in the bottom left of the screen

Additional Information

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

Signed-off-by: Luke McFarlane <luke.mcfarlane@rocketlab.com.au>
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab merged commit 1da0bd8 into main Mar 5, 2025
2 checks passed
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab deleted the fix/extra-space-in-initials branch March 5, 2025 03:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants