Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: 变更 loading 样式为 3 个小圆点 #4

Merged
merged 3 commits into from
Sep 20, 2019
Merged

feat: 变更 loading 样式为 3 个小圆点 #4

merged 3 commits into from
Sep 20, 2019

Conversation

eviIIt
Copy link
Contributor

@eviIIt eviIIt commented Sep 19, 2019 •
edited
Loading

loading-dots

Why

  • 根据内部针对 Log Viewer 组件优化与迭代计划
  • 外观灵感来源
    • zeit/design loading-dots
  • 变更灵感来源
    • gitlab CI
    • travis CI
    • 以及其他...

How

image

Test

$ jest --verbose
 PASS  test/utils/index.test.js
  src/utils/index.js
    ✓ 根据换行符切割字符串 (6ms)
    ✓ 去除开头的控制符 (1ms)
    ✓ 去除尾部的控制符 (1ms)
    ✓ 删除K控制符之前的同一行内容 (2ms)
    ✓ 删除光标控制符

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   0 total
Time:        3.892s
Ran all test suites.

Docs

  • README.md README-zh.md 变更 gif

new-log

Inspiration

@netlify
Copy link

netlify bot commented Sep 19, 2019 •
edited
Loading

Deploy preview for log-viewer ready!

Built with commit b70ac37

https://deploy-preview-4--log-viewer.netlify.com

@eviIIt eviIIt changed the title refactor(ui): 变更 loading 样式为 3 个小圆点 feat(ui): 变更 loading 样式为 3 个小圆点 Sep 20, 2019
@auto-add-label auto-add-label bot added enhancement New feature or request and removed refactor labels Sep 20, 2019
@levy9527 levy9527 changed the title feat(ui): 变更 loading 样式为 3 个小圆点 feat: 变更 loading 样式为 3 个小圆点 Sep 20, 2019
@levy9527 levy9527 merged commit e96beea into FEMessage:dev Sep 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@levy9527 levy9527 levy9527 approved these changes

@lianghx-319 lianghx-319 lianghx-319 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eviIIt @levy9527 @lianghx-319