Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updates for visualization CI #2600

Merged
merged 8 commits into from
Mar 28, 2023
Merged

Updates for visualization CI #2600

merged 8 commits into from
Mar 28, 2023
+14 −21

Conversation

jorgensd
Copy link
Member

@jorgensd jorgensd commented Mar 24, 2023 •
edited
Loading

  • Add IPython to CI
  • Bump pyvista and pyvistaqt version
  • Use python3 -m pip over pip3
  • Change matplotlib backend for TNT demo (to avoid CI issues)
  • Remove pythreejs and ipygany from notebooks, as trame is now preferred

@garth-wells
Copy link
Member

@jorgensd does this fix the CI?

@jorgensd
Copy link
Member Author

@jorgensd does this fix the CI?

The CI has a strange issue with the tnt demo, that doesn’t use pyvista https://github.com/FEniCS/dolfinx/actions/runs/4508930557/jobs/7940462505
ref
https://docs.fenicsproject.org/dolfinx/v0.6.0/python/demos/demo_tnt-elements.html

@garth-wells
Copy link
Member

But it does use Matplotlib.

@jorgensd jorgensd marked this pull request as ready for review March 28, 2023 07:41
@jorgensd
Copy link
Member Author

CI now passes: https://github.com/FEniCS/dolfinx/actions/runs/4540418335/jobs/8001315364

@jorgensd jorgensd changed the title Add ipython to CI for pyvista demos Updates for visualization CI Mar 28, 2023
@jorgensd
Copy link
Member Author

Sigh, seem like a random fluke that it passed

@jorgensd
Copy link
Member Author

Now passing again @garth-wells: https://github.com/FEniCS/dolfinx/actions/runs/4540817530/jobs/8002207371
I changed the backend of matplotlib to not use QT to avoid any issues with pyvista using xvfb

garth-wells
garth-wells reviewed Mar 28, 2023
View reviewed changes
python/demo/demo_tnt-elements.py
@@ -32,6 +33,8 @@

from mpi4py import MPI

matplotlib.use('agg')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgensd could you check that this doesn't affect the Python docs? The docs run this demo to created plots.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine locally:

image

image

@garth-wells garth-wells added this pull request to the merge queue Mar 28, 2023
@mscroggs mscroggs removed this pull request from the merge queue due to a manual request Mar 28, 2023
@mscroggs mscroggs added this pull request to the merge queue Mar 28, 2023
@mscroggs mscroggs removed this pull request from the merge queue due to the queue being cleared Mar 28, 2023
@mscroggs mscroggs added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit 6e67e07 Mar 28, 2023
@mscroggs mscroggs deleted the dokken/pyvista-ci branch March 28, 2023 18:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@garth-wells garth-wells garth-wells approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgensd @garth-wells @mscroggs