Remove installation of build requirements from workflows, since they are already installed in the underlying docker images #2854
Conversation
francesco-ballarin
force-pushed
the
francesco/docker-skbuild
branch
from
f0adb5e to
66623e5
Compare
|
I need to manually rerun https://github.com/FEniCS/dolfinx/actions/workflows/docker-oneapi-test-env.yml and https://github.com/FEniCS/dolfinx/actions/workflows/docker-redhat-test-env.yml for this to work, but I'll wait doing that until the manual rerun by @jhale is finished. |
…are already installed in the underlying docker images
francesco-ballarin
force-pushed
the
francesco/docker-skbuild
branch
from
66623e5 to
30d089a
Compare
|
All base images (ubuntu CI, oneapi and redhat) have been regenerated, and now all workflows are passing. |
| @@ -86,7 +86,6 @@ jobs: | |||
| python3 -m isort --check . | |||
| - name: mypy checks | |||
| run: | | |||
| python3 -m pip install mypy types-setuptools --upgrade # TO REMOVE | |||
There was a problem hiding this comment.
The current workflow upgrades mypy at every run, i.e. if the version of mypy on ghcr.io/fenics/test-env:current-openmpi is old it will get upgraded.
From https://github.com/FEniCS/dolfinx/actions/workflows/docker-dev-test-env.yml I see that the docker-dev-test-env.yml workflow is manually triggered once a month or so, so I do not expect the version of mypy will ever be too old.
There was a problem hiding this comment.
The workflows should not be using pip to install/upgrade dependencies or related tools. Everything should be in the appropriate Dockerfile.
Sometimes it's necessary to install something in a workflow to get the tests to pass and the PR through. The images should then be rebuilt and a cleanup PR created.
It's good practice to add a note e.g. # TO REMOVE as it's easy to forget.
There was a problem hiding this comment.
The only remaining pip install in these three workflows is https://github.com/FEniCS/dolfinx/blame/ef7255b655e96c88ef9556efa982df1c00987cf7/.github/workflows/redhat.yml#L27
which was just added 3 days ago. Do you want me to get rid of that as well?
There was a problem hiding this comment.
The current workflow upgrades
mypyat every run, i.e. if the version ofmypyonghcr.io/fenics/test-env:current-openmpiis old it will get upgraded.From https://github.com/FEniCS/dolfinx/actions/workflows/docker-dev-test-env.yml I see that the
docker-dev-test-env.ymlworkflow is manually triggered once a month or so, so I do not expect the version ofmypywill ever be too old.
You're welcome to try. Would be interesting to see if redhat's pip is up to the task. If not we need to adjust the Dockerfile.
Turns out that most of this was already available in the docker files, but we did not trigger test/dev env workflow.
See https://github.com/FEniCS/dolfinx/actions/runs/6729006694