Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Port DOLFINx to Windows #3198

Merged
merged 234 commits into from
Jun 4, 2024
Merged

Port DOLFINx to Windows #3198

merged 234 commits into from
Jun 4, 2024

Conversation

jhale
Copy link
Member

@jhale jhale commented May 5, 2024

This ports DOLFINx to Windows building against vcpkg using Microsoft Visual C/C++ compiler. It uses an overlay port for Intel MPI (MSMPI does not support neighbourhood collective operations from MPI3). Note that PETSc and petsc4py are not available on Windows.

The primary purpose of this port is to enable conda Windows packages, rather than users building DOLFINx on Windows from source themselves.

Main changes:

  • Windows CI build of DOLFINx including C++ and Python unit tests and Python demos.
  • Disables C99 _Complex when using Windows/MSVC.
  • Allows for Basix to be found without asking Python module for hints -DDOLFINX_BASIX_PYTHON=OFF.
  • Adds note about beta conda windows packages to README.
  • Adds note about vcpkg windows build possibility to README.

Untested but potentially possible:

  • Building against vcpkg on Linux and macOS.
  • Building using a different compiler on Windows.

Outstanding points to tackle in other PRs:

  • High runtime of Python unit tests - should be checked on Conda build. Probably slow JIT.
  • Porting subset of C++ demos to work without PETSc.

@jhale
Copy link
Member Author

jhale commented Jun 3, 2024

Once this runs green it can be re-built on conda-forge. The basix branch should now be unnecessary, I removed the DLL stuff in favour of a proper solution.

@jhale jhale changed the title Build C++ part on Windows Port DOLFINx to Windows Jun 3, 2024
@jhale jhale enabled auto-merge June 4, 2024 09:26
@jhale jhale dismissed garth-wells’s stale review June 4, 2024 10:29

Made all adjustments - let's see how running on PRs go then re-evaluate.

@jhale jhale added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 634f514 Jun 4, 2024
28 of 29 checks passed
@jhale jhale deleted the jhale/windows-build branch June 4, 2024 10:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants