-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Permutation computation refactoring #3223
Permutation computation refactoring #3223
Conversation
|
||
// If min_v is 2 or 3, swap. Why? | ||
if (min_v == 2 or min_v == 3) | ||
min_v = 5 - min_v; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer the why: min_v wants to be the number of vertices anticlockwise away the minimum numbered vertex is. If the vertices were numbered:
3 -- 2
| |
0 -- 1
We wouldn't need to do the swap, but as we use the numbering:
2 -- 3
| |
0 -- 1
we therefore need the swap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mscroggs . Maybe you can add something in-line to document this.
Fixes issue #3208 |
Generalise face permutation computation to get ready for mixed topology meshes.