Generalize all output formats for general length vectors and tensors #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
added
bug
francesco-ballarin
approved these changes
May 23, 2024
garth-wells
previously requested changes
May 27, 2024
chrisrichardson
approved these changes
May 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported at: https://fenicsproject.discourse.group/t/saving-vector-function-with-length-greater-than-the-geometrical-dimension/14752
and follows
#3095
#2848
in supporting arbitrary tensors.
Note that Fides does not support tensors that does not have the shape 3**rank, so I've added a runtime error for it. It is also discussed if we want to remove Fides #3212 due to its limited capabilities, so I don't think it is worth to pursue upstream.