-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Docker simplify (phase 2) #3232
Conversation
I think this is a rather intrusive change, as all CIs must change from All my CIs will now fail and need adjustment, and those that are customized to test against both stable and nightly can no longer be merged into a build matrix without extra arguments. |
Why would a change |
I inferred that from the changes in the CI, where you have replaced |
Will the script at https://github.com/FEniCS/dolfinx/blob/main/docker/dolfinx-real-mode (and similarly I guess I am a bit confused of what having a |
There should be no change required.
|
I dont necessarily agree, as by running pip you do not know what Python installation you are using. Good to know that no changes are required. Is there a specific reason for the build docker and test Ci failing? |
Use a virtual env in the Dockerfile for installing dependencies. This is nicer than overwriting system Python packages when installing/updating. Will also allow advanced users to test Python package versions more freely.