Removed graphics device reset when display event enum is not orientation. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enum is not orientation. SDL2_FNAPlatform.cs: Removed graphics device reset when display event enum is not orientation. This change no longer resets the viewport to 8x8 when the display is connected or disconnected. The reason why the viewport is specifically reset to 8x8 is because the FNA3D.FNA3D_GetMaxMultiSampleCount returns 8. Resetting might make sense if the monitor was swapped entirely with another one. I'm not sure how I can track for when that happens. This has been tested on Windows, but not linux and mac.
|
Looking at the git history this was added because the GraphicsDevice.Adapter property becomes out-of-date when this happens. After this event happens, are you able to find the GraphicsDevice.Adapter instance in GraphicsAdapter.Adapters? Either way we could probably just manually reassign the adapter without doing a whole reset... and for all I know the instance is outdated on XNA too, I'd have to add a second monitor to my VM somehow. |
|
Dug around a bit and I think this was for Axiom Verge 1/2 and it might have been for something unrelated, so yeah let's just update the Adapter manually - if doing that still fixes the issue we can get this in! |
DoubleBullet
deleted the
DoubleBullet-viewport-blur-graphicsdevice-reset-fix
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change no longer resets the viewport to 8x8 when the display is connected or disconnected for a full screen window.
The reason why the viewport is specifically reset to 8x8 is because the FNA3D.FNA3D_GetMaxMultiSampleCount returns 8.
Resetting might make sense if the monitor was swapped entirely with another one. I'm not sure how I can track for when that happens.
This has been tested on Windows, but not linux and mac.
Fixes #500