Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reactor repo #1

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Reactor repo #1

merged 1 commit into from
Aug 2, 2024

Conversation

Jozefiel
Copy link
Contributor

No description provided.

@lhajabacs
Copy link

lhajabacs commented Jul 30, 2024

I would have workers/workflows in different directory (now the worker contains workflows)

that nos project has better structure I think, I would still replace that 'nos' folder with 'app' (to be a better template)

The devices and sample-topology does not belong in the boilerplate I think, I would make another project (or multiple) based on this boilerplate with the sample topology + those UC related workflows

probably this way:

├── build.sh
├── dockerfiles
│   └── Dockerfile
├── LICENSE
├── main.py
├── poetry.lock
├── pyproject.toml
├── README.md
├── app
	└── workflows
	    │── demo_workflow.py
	    │── __init__.py
	   
	└── workers
	    │── demo_worker.py
	    │── __init__.py
	└── core?

@Jozefiel Jozefiel force-pushed the refactor branch 7 times, most recently from bb7e4b4 to 9c8621d Compare August 2, 2024 07:57
@Jozefiel Jozefiel merged commit 5a276f8 into main Aug 2, 2024
1 check passed
@Jozefiel Jozefiel deleted the refactor branch August 2, 2024 12:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants