Merge pull request #16211 from opensourcerouting/fix/dynamic_software…

…_version_sanity_check bgpd: Check if we have really enough data before doing memcpy for software version
FRRouting · Jun 24, 2024 · f047430 · f047430
2 parents 875f1ac + 5d7af51
commit f047430
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
@@ -3695,7 +3695,7 @@ static void bgp_dynamic_capability_software_version(uint8_t *pnt, int action,
 	char soft_version[BGP_MAX_SOFT_VERSION + 1] = {};
 
 	if (action == CAPABILITY_ACTION_SET) {
-		if (data + len > end) {
+		if (data + len + 1 > end) {
 			zlog_err("%pBP: Received invalid Software Version capability length %d",
 				 peer, len);
 			return;