Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use less path normalization due to poor performance on Windows #971

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

sfPlayer1
Copy link
Contributor

This removes some theoretically redundant path normalization, only doing some extra validation with asserts enabled (-ea)

Fixes #970

@MCRcortex
Copy link

Testing this PR it does feel faster to launch (however this might just be a bias/computer having an ok day)

Profiling it, path normalization is completely eliminated from the profiler.

All threads:
image

Render thread:
image

Confirmed this PR removed the bottleneck of path normalization on windows.

Launch time (appears) to be on par with vanilla (no mod loader)

Thank you for the fix!

@modmuss50 modmuss50 merged commit fcd01e5 into FabricMC:master Sep 3, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance] LoaderUtil.normalizePath on windows takes a significant amount of launch time
3 participants