Fix modded oxidizable blocks not oxidizing #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes FabricMC#4371 `OxidizableBlocksRegistry.registerOxidizableBlockPair` will now re-cache the value of the `ticksRandomly` field of the passed blocks' states to ensure that the default implementation of oxidization will actually work on the blocks. This may be considered a slightly dirty workaround, but it works well and isn't particularly intrusive, despite using 2 mixins. I've also included a test (though not a GameTest) to ensure that this works, and split the `OxidizableBlocksRegistry` into separate API and impl classes to more easily allow for potential extensibility in future while not breaking compatibility.
|
Um, not sure why the data attachment API gametest failed, I didn't touch that at all... |
|
It fails intermittently, don't worry about it |
PepperCode1
approved these changes
Feb 12, 2025
modmuss50
approved these changes
Feb 12, 2025
modmuss50
pushed a commit
that referenced
this pull request
Feb 15, 2025
Fixes #4371 `OxidizableBlocksRegistry.registerOxidizableBlockPair` will now re-cache the value of the `ticksRandomly` field of the passed blocks' states to ensure that the default implementation of oxidization will actually work on the blocks. This may be considered a slightly dirty workaround, but it works well and isn't particularly intrusive, despite using 2 mixins. I've also included a test (though not a GameTest) to ensure that this works, and split the `OxidizableBlocksRegistry` into separate API and impl classes to more easily allow for potential extensibility in future while not breaking compatibility. (cherry picked from commit 25d1a67)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4371 and #4226
OxidizableBlocksRegistry.registerOxidizableBlockPairwill now re-cache the value of theticksRandomlyfield of the passed blocks' states to ensure that the default implementation of oxidization will actually work on the blocks.This may be considered a slightly dirty workaround, but it works well and isn't particularly intrusive, despite using 2 mixins.
I've also included a test (though not a GameTest) to ensure that this works, and split the
OxidizableBlocksRegistryinto separate API and impl classes to more easily allow for potential extensibility in future while not breaking compatibility.