Add contains method to FabricComponentMapBuilder #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Feb 16, 2025
modmuss50
added
enhancement
modmuss50
pushed a commit
that referenced
this pull request
Feb 20, 2025
* add contains method * fix javadoc checkstyle i think (cherry picked from commit ee91fa1)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of components (such as
minecraft:unbreakable) work based on presence in the map - they do not store a boolean flag in the component. Using thegetmethods have the side effect of adding the component to the builder map. So, if one of the presence-based components tries to be checked using one of those methods, then it will add them to the map even if that is not the intention. This PR aims to address that by adding a simplecontainsmethod that does not add the component and has no side effects.