Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change elytra event mixin injection point #4447

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

PrimordialMoros
Copy link
Contributor

The EntityElytraEvents.CUSTOM allows specifying your own condition for enabling elytra gliding. However, vanilla code checks all applicable slots for items that allow gliding. If you are using a custom condition instead of an item then an empty list is supplied which causes a crash due to an index check in Util.getRandom.

Moved the injection point for the EntityElytraEvents to avoid this issue.

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes sense. Thanks.

@modmuss50 modmuss50 added bug Something isn't working merge me please Pull requests that are ready to merge labels Feb 19, 2025
@modmuss50 modmuss50 merged commit da99546 into FabricMC:1.21.4 Feb 20, 2025
4 checks passed
modmuss50 pushed a commit that referenced this pull request Feb 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working merge me please Pull requests that are ready to merge small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants