Verify V11

FaeyUmbrea · Jun 15, 2023 · 99aa424 · 99aa424
1 parent cd39cd7
commit 99aa424
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 2 deletions.
diff --git a/public/module.json b/public/module.json
@@ -7,7 +7,7 @@
   "manifestPlusVersion": "1.2.0",
   "compatibility": {
     "minimum": 10,
-    "verified": 10,
+    "verified": 11,
     "maximum": 11
   },
   "authors": [

diff --git a/src/index.js b/src/index.js
@@ -25,7 +25,9 @@ function start() {
     if (game.view === "game") {
       const ui = await import("./utils/ui.js");
       await ui.registerUI();
-      await ui.showNotifications();
+
+      // Show notifications panel if UI is loaded
+      Hooks.once("ready", () => ui.showNotifications());
     }
 
     // Load OBS Stuff only in OBS

diff --git a/src/svelte/NotificationCenterUI.svelte b/src/svelte/NotificationCenterUI.svelte
@@ -4,12 +4,17 @@
   import { ApplicationShell } from "@typhonjs-fvtt/runtime/svelte/component/core";
   import notifications from "../utils/notifications.json";
   import CollapsibleSection from "./components/CollapsibleSection.svelte";
+  import { setSetting } from "../utils/settings.js";
+  import { onDestroy } from "svelte";
 
   export let elementRoot = void 0;
 
   function openLink(uri) {
     window.open(uri, "_blank").focus();
   }
+  onDestroy(() => {
+    setSetting("lastReadNotification", notifications[0].id);
+  });
 </script>
 
 <ApplicationShell bind:elementRoot="{elementRoot}">

diff --git a/src/utils/ui.js b/src/utils/ui.js
@@ -94,6 +94,7 @@ export async function registerUI() {
 }
 
 export function showNotifications() {
+  if (!game.user.isGM) return;
   const lastRead = getSetting("lastReadNotification");
   if (lastRead < notifications[0].id) {
     new NotificationCenter().render(true);

diff --git a/tests/test.spec.js b/tests/test.spec.js
@@ -76,6 +76,9 @@ test.describe("DM Client Only Tests", () => {
 
     await gmPage.waitForFunction(() => window["game"].ready);
   });
+  test("Close Notification Center", async () => {
+    await closeNoficationCenter(gmPage);
+  });
   test("Click Director Button to Open and Close", async () => {
     await openDirector(gmPage);
 
@@ -561,6 +564,16 @@ async function endCombat(gmPage) {
     .waitFor({ state: "hidden" });
 }
 
+async function closeNoficationCenter(gmPage) {
+  await expect(
+    gmPage.locator("div[id=notification-application]")
+  ).toBeVisible();
+  await gmPage.locator("div[id=notification-application] a.close").click();
+  await expect(
+    gmPage.locator("div[id=notification-application]")
+  ).not.toBeVisible();
+}
+
 async function openDirector(gmPage) {
   await gmPage.locator("li[data-tool=openStreamDirector]").click();
   await expect(gmPage.locator("div[id=director-application]")).toBeVisible();