Fix new-delete-type-mismatch in BaseEventHandlersImpl.h #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbx , thank you. Great catch! |
|
Awesome, thanks for the merge! Could you make a patch tag with this so I can include that in the CI? Thankie |
|
Done. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373, which continuously leads to test failures in ODC: https://cdash.gsi.de/testDetails.php?test=21606495&build=473806
The issue is that SHandlerHlpBaseFunc containing
T m_signalis stored in astd::map<Event_t, std::unique_ptr<SHandlerHlpFunc>> signalsContainer_t;, with pointers to the base type. And since the base type has no virtual destructor, it then does not take care of deleting child's objects properly.I tested this change locally and it fixes the new-delete-type-mismatch.