Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"Whitespace" (unchanged lines) in Diff view #14

Closed
FaithfulDev opened this issue May 4, 2019 · 0 comments
Closed

"Whitespace" (unchanged lines) in Diff view #14

FaithfulDev opened this issue May 4, 2019 · 0 comments
Assignees
@FaithfulDev
Labels
improvement Some kind of improvement for a function already implemented.
Milestone
v1.0.2

Comments

@FaithfulDev
Copy link
Owner

To make the Diff view more easily to read there should be "Whitespace" (unchanged lines) around the changed lines in the diff. 3 unchanged lines above and below the block of changes should be enough.

Since this might cause diff blocks to overlap, it is necessary to combine diff blocks, in that event.

This number of lines should be implemented as a user setting, to make it changeable in later versions.
@FaithfulDev FaithfulDev added the improvement Some kind of improvement for a function already implemented. label May 4, 2019
@FaithfulDev FaithfulDev added this to the v1.0.2 milestone May 4, 2019
@FaithfulDev FaithfulDev self-assigned this May 4, 2019
FaithfulDev added a commit that referenced this issue May 19, 2019
@FaithfulDev
implements #14, implements #16, implements #17 - Diff view improvements
94f3a0a 
There are now whitespace lines in the diff view. Also the font "Consolas" is used and the line numbers are padded to right-align.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@FaithfulDev FaithfulDev

Labels
improvement Some kind of improvement for a function already implemented.
Projects
None yet
Milestone
v1.0.2
Development

No branches or pull requests
1 participant
@FaithfulDev