Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix rgba value in oven_asset.xml to be in [0,1] #262

Merged

Conversation

RussTedrake
Copy link
Contributor

Description

The mujoco xml docs state that "All [rgba] components should be in the range [0 1]."
https://mujoco.readthedocs.io/en/stable/XMLreference.html#asset-material

MuJoCo's parser clearly let's this through. But it seems that mine is a little more strict.

I checked with the original author @abhishekunique, and he confirmed that it's just a bug (from his original work), and that it should be fixed.

Related to RobotLocomotion/drake#22445.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

The mujoco xml docs state that "All [rgba] components should be in the
range [0 1]."
https://mujoco.readthedocs.io/en/stable/XMLreference.html#asset-material

MuJoCo's parser clearly let's this through. But it seems that mine is
a little more strict.

I checked with the original author @abhishekunique, and he confirmed
that it's just a bug (from his original work), and that it should be
fixed.
@Kallinteris-Andreas Kallinteris-Andreas changed the title Fix rgba value in oven_asset.xml to be in [0,1] Fix rgba value in oven_asset.xml to be in [0,1] Jan 19, 2025
@Kallinteris-Andreas Kallinteris-Andreas merged commit 40d4212 into Farama-Foundation:main Jan 19, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants