Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Documentation Frozen Lake : precise is_slippery true by default #136

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Documentation Frozen Lake : precise is_slippery true by default #136

merged 5 commits into from
Nov 17, 2022

Conversation

MarionPlt
Copy link
Contributor

Description

Precise that is_slippery is true by default.

Fixes # (135)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MarionPlt MarionPlt mentioned this pull request Nov 16, 2022
Closed
1 task
pseudo-rnd-thoughts
pseudo-rnd-thoughts reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment for initialising environment with this option?

Within the docstring after the description of the option

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit f037fde into Farama-Foundation:main Nov 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarionPlt @pseudo-rnd-thoughts