Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MuJoCo.Ant-v4.use_contact_forces add doc #183

Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

Description

use_contact_forces was previously not mentioned in the doc, and the Observation Space was misleading because of it
now it does

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [no] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • [yes] I have commented my code, particularly in hard-to-understand areas
  • [yes] I have made corresponding changes to the documentation
  • [yes] My changes generate no new warnings
  • [Does not apply] I have added tests that prove my fix is effective or that my feature works
  • [did not test] New and existing unit tests pass locally with my changes

`use_contact_forces` was previously not mentioned in the doc, and the `Observation Space` was misleading because of it
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, that is very helpful

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 90cca7c into Farama-Foundation:main Dec 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants