Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added vector env support to StepAPICompatibility wrapper. #238

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

nidhishs
Copy link
Contributor

@nidhishs nidhishs commented Jan 5, 2023

Description

This PR adds support for vector environments in StepAPICompatibility wrapper. Previously, the wrapper was incompatible due to not passing proper flag to the underlying step_api_compatibility utility function.

Fixes #237

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this looks good

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit e8897ff into Farama-Foundation:main Jan 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] StepAPICompatibility wrapper incompatible with Vector Environments
2 participants