Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix AttributeError in lunar_lander.py #278

Merged
merged 3 commits into from
Jan 21, 2023

Conversation

DrRyanHuang
Copy link
Contributor

@DrRyanHuang DrRyanHuang commented Jan 20, 2023

Description

fix AttributeError of lunar_lander.py

when I run python gymnasium/envs/box2d/lunar_lander.py, it raise,

AttributeError: 'NoneType' object has no attribute 'id'

self.spec is None, so it has no attribute 'id'.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Before After
image image

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@DrRyanHuang DrRyanHuang changed the title Update lunar_lander.py Fix AttributeError in lunar_lander.py Jan 20, 2023
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify it to replace LunarLander() within the __main__ part to gym.make("LunarLander-v2")

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 92fd439 into Farama-Foundation:main Jan 21, 2023
@DrRyanHuang DrRyanHuang deleted the patch-1 branch January 21, 2023 14:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants