Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix and Update Basic Usage's and Core page #41

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

vairodp
Copy link
Contributor

@vairodp vairodp commented Oct 7, 2022

Description

Fix the Basic Usage page docs, by updating the code, fixing it, and also fixing the grammar.
In the second commit I fixed also the API -> Core page, by removing deprecated docs, fixing grammar and inconsistencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vairodp vairodp changed the title Fix and Update Basic Usage's page Fix and Update Basic Usage's and Core page Oct 8, 2022
@pseudo-rnd-thoughts
Copy link
Member

Amazing, I will read through all of the changes tomorrow evening.
Are you going to review any more files for this PR?

@vairodp
Copy link
Contributor Author

vairodp commented Oct 9, 2022

Amazing, I will read through all of the changes tomorrow evening. Are you going to review any more files for this PR?

Not in this PR, my plan is to do a PR for every "section" of work that I'm doing and I've already done another PR for the tutorial section.
If you think is a bad idea I can continue my work in this PR

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except for the gymn to gym

gymnasium/core.py Outdated Show resolved Hide resolved
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit c2e2df2 into Farama-Foundation:main Oct 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants