Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix TypeError when closing rendering #440

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

sonelu
Copy link
Contributor

@sonelu sonelu commented Apr 7, 2023

Fixes #438

Description

Fixes TypeError exception that can appear when finishing with an environment that was rendered.

Fixes #438

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas
Copy link
Collaborator

LGTM, from my testing it does fix the issue, and does not appear to break anything here or in Gymansium-Robotics

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit a910eae into Farama-Foundation:main Apr 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] TypeError: 'NoneType' object is not callable in /mujoco_rendering.py in free
3 participants