Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Docs] Custom environment tutorial refactoring #709

Merged

Conversation

kir0ul
Copy link
Contributor

@kir0ul kir0ul commented Sep 8, 2023

Description

This PR refactors the custom environment tutorial to use the https://github.com/Farama-Foundation/gymnasium-env-template.

Fixes #669 and #674.

Type of change

  • Documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks

@ernestum
Copy link

ernestum commented Sep 8, 2023

Looks good now. Thanks for fixing this!

@pseudo-rnd-thoughts
Copy link
Member

@kir0ul Is this good to merge?

@kir0ul
Copy link
Contributor Author

kir0ul commented Sep 10, 2023

@kir0ul Is this good to merge?

I think so, I also fixed some minor issues with the FrozenLake tutorial if you don't mind.

@kir0ul kir0ul marked this pull request as ready for review September 10, 2023 14:09
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit baf7807 into Farama-Foundation:main Sep 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Outdated API documentation in custom environment tutorial
3 participants