Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mark mujoco-py environments as explicity deprecated #926

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Feb 16, 2024

Description

This PR simply changes the documentation to explicitly state that mujoco-py are deprecated

since this issue, it is clear that the inclusion of the old MuJoCo environments causes issues to user who do not interact with it

I am not sure about when, the removal of mujoco-py environments will happen, probably after 1.0, maybe with the release of py313?

Fixes # (issue)

Type of change

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review February 16, 2024 07:59
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, at this point the number of projects using mujoco-py and gymnasium is very low.

For v1.0.0, I think we keep the environment but after that, we cut them maybe.

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit e2329b8 into main Feb 16, 2024
16 checks passed
@pseudo-rnd-thoughts
Copy link
Member

It would make sense to move to Gymnasium-robotics I believe, @Kallinteris-Andreas how do you feel about that?

@Kallinteris-Andreas
Copy link
Collaborator Author

Kallinteris-Andreas commented Feb 17, 2024

depends on how compatible it is with py3.13, if it is too much work, i will drop support

@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the Kallinteris-Andreas-patch-10 branch February 19, 2024 22:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants