Use CsharpNamespace when Package is empty in ConfluentProtobufTypeResolver #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a basic implementation of the issue addressed here: #404
How Has This Been Tested?
Unit tests for
ConfluentProtobufTypeResolver
has been created (ConfluentProtobufTypeNameResolverTests
).Two cases are tested there, one when
Package
is non-empty and the second whenPackage
is empty butCsharpNamespace
is available.Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement