Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

shirt layout works, issue #1241 #1242

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

richardhenwood
Copy link
Contributor

This fix means the shirt fullsleeve doesn't overlap other blocks on layout. See the issue here:
#1241

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

what-the-diff bot commented Jan 30, 2025

PR Summary 🌈

  • Design Improvement to our Virtual Wardrobe 🎨
    We added a new attribute called "angle" to the node element in our graphical representation of the male shirt. This will give us more control of how the shirt appears and significantly enhance the user experience for our fashion enthusiasts. 🕺👔🎉

@FashionFreedom FashionFreedom deleted a comment from richardhenwood Feb 9, 2025
@slspencer
Copy link
Collaborator

Thanks @richardhenwood !!

Signed-off-by: DSCaskey <31944718+DSCaskey@users.noreply.github.com>
Copy link
Contributor

@DSCaskey DSCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @richardhenwood .

The issue though is not with the SA angle, but rather the control point angle of the spline at point C14.

image

Screenshot 2025-02-11 001951

image

Screenshot 2025-02-11 002039

Leaving the SA angle as it was and adjusting the control point angle removes the glitch and fixes the pattern.

@DSCaskey DSCaskey merged commit 5dd7736 into FashionFreedom:develop Feb 11, 2025
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants