-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Deprecate "exact values" setting from JsonNodeFactory
, replace with JsonNodeFeature.STRIP_TRAILING_BIGDECIMAL_ZEROES
#3651
Labels
node-config
Related to JSTEP-7 Node config/feature
Comments
cowtowncoder
added
3.x
Issues to be only tackled for Jackson 3.x, not 2.x
node-config
Related to JSTEP-7 Node config/feature
labels
Nov 6, 2022
cowtowncoder
added a commit
that referenced
this issue
Nov 6, 2022
cowtowncoder
changed the title
Remove "exact values" setting from
Remove "exact values" setting from Nov 7, 2022
JsonNodeFactory
, replace with JsonNodeFeature.NORMALIZE_BIG_DECIMAL
JsonNodeFactory
, replace with JsonNodeFeature.STRIP_BIG_DECIMAL_ZEROES
cowtowncoder
changed the title
Remove "exact values" setting from
Deprecate "exact values" setting from Jan 25, 2023
JsonNodeFactory
, replace with JsonNodeFeature.STRIP_BIG_DECIMAL_ZEROES
JsonNodeFactory
, replace with JsonNodeFeature.STRIP_TRAILING_BIGDECIMAL_ZEROES
cowtowncoder
added a commit
that referenced
this issue
Jan 25, 2023
cowtowncoder
added
2.15
and removed
3.x
Issues to be only tackled for Jackson 3.x, not 2.x
labels
Jan 25, 2023
cowtowncoder
added a commit
that referenced
this issue
Jan 25, 2023
valfirst
added a commit
to vividus-framework/vividus
that referenced
this issue
Apr 25, 2023
valfirst
added a commit
to vividus-framework/vividus
that referenced
this issue
Apr 26, 2023
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
(note: follow-up to #3650)
With Jackson 2.x there is a setting in
JsonNodeFactory
that determines whetherBigDecimal
values are normalized upon read (default) or not. Default value of normalization seems surprising to users, but there is a use-case for normalization too (specifically, trying to normalizeJsonNode
s to be logically equal for comparisons).There are 2 main problems:
JsonNodeFactory
is non-obvious and cumbersomeChanging 2 would be easy, but changes behavior so will need to wait either until 3.0, or at least 2.16 if and when the other part goes in 2.15.
So let's:
JsonNodeFeature.STRIP_TRAILING_BIGDECIMAL_ZEROES
, to have precedence over other settingsJsonNodeFactory
setting in place, deprecatedJsonNodeDeserializer
) NOT inJsonNodeFactory
This allows users to migrate to using
JsonNodeFeature.STRIP_TRAILING_BIGDECIMAL_ZEROES
for configurability while retaining old behavior for old code.We can then consider default changes for a later version, separately.
The text was updated successfully, but these errors were encountered: