Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

StdDelegatingSerializer does not consider a Converter that may return null for a non-null input #4576

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

plevart
Copy link
Contributor

@plevart plevart commented Jun 12, 2024

This is a fix for #4575 complete with unit test that fails without the fix and passes with the fix.

@cowtowncoder
Copy link
Member

Thank you @plevart for both reporting the issue and contributing a fix!

One thing I'd need before merging it is CLA (unless you have sent one earlier):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print it, fill & sign, scan/photo, email to cla at fasterxml dot com.
Once I have it, I can merge this PR (and probably backport in 2.17 as well, seems safe enough).

Thank you again!

}
};

ObjectMapper mapper = jsonMapperBuilder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using builder since "ObjectMapper.registerModule()" removed from 3.0, builder-approach easier to merge forward.

@cowtowncoder cowtowncoder merged commit 86cf6d0 into FasterXML:2.18 Jun 13, 2024
9 checks passed
@cowtowncoder
Copy link
Member

Merged, will backport to 2.17(.2) next

@cowtowncoder cowtowncoder added this to the 2.17.0 milestone Jun 13, 2024
cowtowncoder pushed a commit that referenced this pull request Jun 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants