Before epoch fix #132
Before epoch fix #132
Conversation
seconds value already has the correct sign, so remove the sign from the nanos part
This reverts commit b3588cf.
|
Argh. I may have to switch to command line commits, this GitHub UI is clickity-clickity. Build failed, but that is because GitHub is not syncing up correctly with local changes somehow. Will fix that, and then adjust the 'work-in-progress' to 'ready for review'. |
fix serialization/deserialization for ZoneDateTime for times before epoch
|
Not sure where to specify bug this is associated with: |
…alization deserialization issue number 120
|
This also fixes #120 |
...time/src/test/java/com/fasterxml/jackson/datatype/jsr310/TestZonedDateTimeSerialization.java
Outdated
Show resolved
Hide resolved
|
@kupci could you add the test case in #120 (comment) (if this does fix #120)? |
Yes, I've got that test case from the issue included in the test suite. |
|
@cowtowncoder this PR looks good to me - do you think it is ok to merge it? |
|
@pjfanning Ok. So, to get this 2.10 I can... I think I'll merge this, just backport. |
|
Finally got this merged: thank you everyone for getting this annoying long-time bug fixed. |
Disable failing tests - Refs ThreeTen/threetenbp#185 - Refs FasterXML/jackson-modules-java8#132 - Refs FasterXML/jackson-modules-java8#267
….2 (#139) Disable failing tests - Refs ThreeTen/threetenbp#185 - Refs FasterXML/jackson-modules-java8#132 - Refs FasterXML/jackson-modules-java8#267
….2 (#139) Disable failing tests - Refs ThreeTen/threetenbp#185 - Refs FasterXML/jackson-modules-java8#132 - Refs FasterXML/jackson-modules-java8#267
No description provided.