Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[connectors] Removed log duplicities #317

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[connectors] Removed log duplicities #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FastyBird/Connector/HomeKit/src/Controllers/PairingController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@ private function verifyFinish(
$client = $this->clientsRepository->findOneBy($findClientQuery);

if ($client === null) {
$this->logger->error(
$this->logger->debug(
'Pairing client instance is not created',
[
'source' => MetadataTypes\Sources\Connector::HOMEKIT->value,
Expand Down
24 changes: 0 additions & 24 deletions src/FastyBird/Connector/Shelly/src/API/Gen2WsApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,18 +332,6 @@ function (Socket\ConnectionInterface $conn) use ($request, $negotiator, $connect
$this->connecting = false;
$this->connected = false;

$this->logger->error(
'Could not create device client',
[
'source' => MetadataTypes\Sources\Connector::SHELLY->value,
'type' => 'gen2-ws-api',
'exception' => ApplicationHelpers\Logger::buildException($ex),
'device' => [
'id' => $this->id->toString(),
],
],
);

$connecting->then(static function (Socket\ConnectionInterface $connection): void {
$connection->close();
});
Expand Down Expand Up @@ -844,18 +832,6 @@ function (RFC6455\Messaging\MessageInterface $socketMessage): void {
);

$connection->on('error', function (Throwable $ex): void {
$this->logger->error(
'An error occurred on device connection',
[
'source' => MetadataTypes\Sources\Connector::SHELLY->value,
'type' => 'gen2-ws-api',
'exception' => ApplicationHelpers\Logger::buildException($ex),
'device' => [
'id' => $this->id->toString(),
],
],
);

$this->lost();

Utils\Arrays::invoke($this->onError, $ex);
Expand Down
2 changes: 1 addition & 1 deletion src/FastyBird/Connector/Shelly/src/Clients/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public function connect(): void
unset($this->gen2DevicesWsClients[$device->getId()->toString()]);

$this->logger->error(
'Device websocket connection could not be created',
'Connection with device through websocket could not be created',
[
'source' => MetadataTypes\Sources\Connector::SHELLY->value,
'type' => 'local-client',
Expand Down
Loading