Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

kubefate cluster installation with correct fateflow python-0 pv size … #860

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

PenHsuanWang
Copy link
Contributor

…setting. issue #859

Fixes ISSUE #859

Description

To correctly set the fateflow PV from the cluser.yaml without bounding mysql PV setting.

@owlet42
Copy link
Collaborator

owlet42 commented Feb 28, 2023

Thanks for your PR, KubeFATE requires all commits to go through DCO.

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin fateflow-pv-setting-issue

…setting. issue FederatedAI#859

Signed-off-by: PenHsuanWang <willy118116@gmail.com>
@PenHsuanWang PenHsuanWang force-pushed the fateflow-pv-setting-issue branch from bdee606 to f7b74bd Compare February 28, 2023 16:05
Copy link
Collaborator

@owlet42 owlet42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owlet42 owlet42 added the hotfix label Mar 6, 2023
@owlet42 owlet42 merged commit e27f746 into FederatedAI:master Mar 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants