-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
css_inline pinned to < 0.12 but newer versions seem to work #55
Comments
I think it might still make sense to still pin to 0.13, since we've already been burned before by css_inline changing its API, but I don't feel strongly. |
Ok, I just relaxed the version requirement to Personally I'd relax the version requirement even more but I'm fine with restricting it assuming that you could monitor |
@caseyjhol |
I was trying to see if poetry supported pinning sub-dependency versions (similar to NPM's overrides or Yarn's resolutions), but unfortunately no such luck (python-poetry/poetry#697). I suppose I'm okay with relaxing the version requirement here. I've been burned enough times in the past by changing APIs and broken dependencies that I always use strict versioning for my dependencies any more (especially for dependencies that are v0.x and could change anything at any time). But for something like inlining CSS the risks are probably pretty minimal. |
@caseyjhol We have
css_inline
pinned to>= 0.11, < 0.12
but the most recent version is0.13.0
already. I just installed the newer version and all tests still pass. Any objections of removing the upper limit completely?The text was updated successfully, but these errors were encountered: