Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix hybrid CPU core pinning #455

Conversation

patatahooligan
Copy link
Contributor

@patatahooligan patatahooligan commented Jan 3, 2024

Previously the condition would always evaluate to false. With the fix any core with >=95% of max_freq will be added to the set of cores to keep.

I tested this on my system with a 13600k by comparing the results of running a make -j20 job with and without gamemode. With gamemode I saw the expected results, namely:

  • only the first 12 cores showing significant usage with the rest being close to 0%.
  • taskset -ap $PID returning fff for the make process, instead of the default fffff.

Fixes #451.

Previously the condition would always evaluate to `false`. With the fix
any core with >=95% of `max_freq` will be added to the set of cores to
keep.
@afayaz-feral afayaz-feral merged commit 8cea4c2 into FeralInteractive:master Jan 3, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gamemode doesn't detect 13600KF as big.LITTLE properly
2 participants