Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove text underline on o footer services links #1960

Open
wants to merge 1 commit into
base: 2025-release
Choose a base branch
from

Conversation

frshwtr
Copy link
Contributor

@frshwtr frshwtr commented Feb 5, 2025

Describe your changes

Removes a text underline that appeared on footer-links demo post migrating to o-private-foundation.

Issue ticket number and link

Link to Figma designs

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@j-mes
Copy link
Member

j-mes commented Feb 5, 2025

Should this be merging into 2025-release branch? As I'm seeing 212 commits 😱

@frshwtr frshwtr changed the base branch from main to 2025-release February 7, 2025 13:36
Copy link
Member

@j-mes j-mes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

FWIW: Once this is in with Lee's PR, the failing test will no longer exist

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants