Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

S3: enable overriding x-amz-date from signing server #2021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ViliamKopecky
Copy link

Brief description of the changes

AWS S3 SDK using PostObjectV4 (https://docs.aws.amazon.com/aws-sdk-php/v3/api/class-Aws.S3.PostObjectV4.html) doesnt let you set custom date for policy, and sometimes the dates are different about a second, so the better way for me is setting the date from server.

Maybe even better way would be setting the whole awsParams from server.

What browsers and operating systems have you tested these changes on?

macos chrome

Have you written unit tests? If not, explain why.

I didnt find existing matching test for this.

@donbobka
Copy link

donbobka commented Nov 8, 2018

+1 to enable overriding of any field (not only date)?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants