Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

During shutdown op_disconnect may be sent to invalid handle #7296

Closed
AlexPeshkoff opened this issue Sep 7, 2022 · 2 comments
Closed

During shutdown op_disconnect may be sent to invalid handle #7296

AlexPeshkoff opened this issue Sep 7, 2022 · 2 comments
Assignees
@AlexPeshkoff
Labels
affect-version: 3.0.10 affect-version: 4.0.2 fix-version: 3.0.11 fix-version: 4.0.3 fix-version: 5.0 Beta 1 type: bug

Comments

@AlexPeshkoff
Copy link
Member

Reported privately by artyom.abakumov artyom.abakumov@red-soft.ru

In Dispatcher::shutdown() providers are first disabled and then service and attachment interfaces are searched for and disabled. For remote provider connections are closed via force_close(), which is why release() of attachments and/or services cause sending op_disconnect using incorrect port_handle value.
@AlexPeshkoff AlexPeshkoff self-assigned this Sep 7, 2022
@AlexPeshkoff AlexPeshkoff reopened this Sep 7, 2022
AlexPeshkoff added a commit that referenced this issue Sep 12, 2022
@AlexPeshkoff
Fixed #7296: During shutdown op_disconnect may be sent to invalid handle
d86e4d0 
(cherry picked from commit 77e711a)
AlexPeshkoff added a commit that referenced this issue Sep 12, 2022
@AlexPeshkoff
Fixed #7296: During shutdown op_disconnect may be sent to invalid handle
212575e 
(cherry picked from commit 77e711a)
@AlexPeshkoff
Copy link
Member Author

Found related bug, caused by this fix: #7504 (Segfault when closing SQL statement in remote provider during shutdown)

@AlexPeshkoff AlexPeshkoff reopened this Mar 17, 2023
AlexPeshkoff added a commit that referenced this issue Mar 17, 2023
@AlexPeshkoff
Postfix for #7296: During shutdown op_disconnect may be sent to inval…
017f313 
…id handle; fixed segfault caused by too early destroyed port_context
AlexPeshkoff added a commit that referenced this issue Mar 24, 2023
@AlexPeshkoff
Postfix for #7296: During shutdown op_disconnect may be sent to inval…
62e6156 
…id handle; fixed segfault caused by too early destroyed port_context

(cherry picked from commit 017f313)
@AlexPeshkoff
Copy link
Member Author

Postfixes added to affected branches

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@AlexPeshkoff AlexPeshkoff

Labels
affect-version: 3.0.10 affect-version: 4.0.2 fix-version: 3.0.11 fix-version: 4.0.3 fix-version: 5.0 Beta 1 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexPeshkoff