mk/4.0/gcc6 #18
Merged
mk/4.0/gcc6 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkubecek what about my comment regarding -fno-delete-null-pointer-checks in CORE-5099? -fno-delete-null-pointer-checks: becase the ->as ->is methods that we call in null pointers. May have others similar things. |
|
That one is still needed. I plan to look into it as well. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch allows to build with gcc6 in C++14 mode without -fno-sized-deallocation option. Second fixes a misleading indentation gcc6 warns about.