This repository has been archived by the owner on Jun 16, 2018. It is now read-only.
Ranking only published scores #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(even if they have certain errors).
poelstra
force-pushed
the
ranking_only_published_scores
branch
from
616702a to
e912be6
Compare
kmeesters
reviewed
Oct 10, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #245.
This switches the ranking to include only published scores.
Tests were updated accordingly.
Note: there are two 'strange' changes: removal of check for DuplicateScoreError and removal of haveFilter condition. Both of these are also already removed (and explained) in #286, so can be ignored for this PR.
If #286 is merged first, I can fixup this PR to get rid of these two changes, if needed.