Feature/strict concurrency split #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agsmith#48) * - Bumped `swift-tools` to swift 5.9. - Enabled `StrictConcurrency=complete` mode in order to be prepared for upcoming Swift 6. Implemented `Sendable` support for Flagsmith client and friends. - Enabled `ExistentialAny` feature in order to be prepared for upcoming Swift 6. Code adjustments - adjusted tests for `StrictConcurrency=complete` mode . * adjusted macOS runner * cleanup
…/strict-concurency
…e runners to check everything is fine
# Conflicts: # Example/FlagsmithClient/AppDelegate.swift # FlagsmithClient/Classes/Feature.swift # FlagsmithClient/Classes/Flag.swift # FlagsmithClient/Classes/Flagsmith.swift # FlagsmithClient/Classes/FlagsmithError.swift # FlagsmithClient/Classes/Internal/APIManager.swift # FlagsmithClient/Classes/Internal/FlagsmithAnalytics.swift # FlagsmithClient/Classes/Trait.swift # FlagsmithClient/Classes/TypedValue.swift # FlagsmithClient/Classes/UnknownTypeValue.swift # FlagsmithClient/Tests/APIManagerTests.swift # Package.swift
matthewelwell
approved these changes
May 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes and includes #48.
This PR updates the above by also updating the Cocoapods functionality to match the Swift Package Manager changes above: 6b5dc80
The changes here can look complicated, but the main change from a functionality perspective is the introduction 'existential any'. There's a good article here - https://www.avanderlee.com/swift/existential-any/.
Type of Change
✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore