Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Segment change requests #4852

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

feat: Segment change requests #4852

wants to merge 19 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 20, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adds change requests for segments
  • Adds a new project setting for change requests
  • Moves the change request/requests pages to typescript
  • Adds an existing change request warning for the create segment modal

image

How did you test this code?

Please describe.

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 20, 2024 13:31
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ❌ Failed (Inspect) Dec 18, 2024 10:28am
flagsmith-frontend-staging ❌ Failed (Inspect) Dec 18, 2024 10:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 10:28am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4852 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4852 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4852 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4852 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4852 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4852 Finished ✅ Results ✅

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 20, 2024
@kyle-ssg kyle-ssg marked this pull request as draft November 20, 2024 13:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-58410

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4852

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4852

⚙️ Updating now by workflow run 12050592695.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 20, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 20, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 20, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 20, 2024
@github-actions github-actions bot added the feature New feature or request label Nov 27, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2024
@matthewelwell matthewelwell mentioned this pull request Dec 10, 2024
Open
4 tasks
@kyle-ssg
Copy link
Member Author

Awaiting backend fixes

@kyle-ssg kyle-ssg linked an issue Dec 18, 2024 that may be closed by this pull request
UI work to add Change Requests for segments #4844
Open
@kyle-ssg
Merge branch 'refs/heads/main' into feat/segment-change-requests
2d4be05 
# Conflicts:
#	frontend/common/services/useFeatureVersion.ts
#	frontend/common/types/requests.ts
#	frontend/web/components/pages/ChangeRequestPage.js
#	frontend/web/components/pages/EnvironmentSettingsPage.js
#	frontend/web/components/pages/ProjectSettingsPage.js
@kyle-ssg
Merge main
4be99e7
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI work to add Change Requests for segments
1 participant
@kyle-ssg