Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make flank-scripts features not depends on each other #1543

Closed
jan-goral opened this issue Jan 28, 2021 · 1 comment · Fixed by #1572
Closed

Make flank-scripts features not depends on each other #1543

jan-goral opened this issue Jan 28, 2021 · 1 comment · Fixed by #1572
Assignees
@adamfilipow92
Labels
Refactor Tiger 🐯
Milestone
Sprint 1

Comments

@jan-goral
Copy link
Contributor

jan-goral commented Jan 28, 2021 •
edited
Loading

Author the user story for this feature

As a contributor, I want to keep features not dependent on each other so I don't have to be afraid of the hidden complexity of the domain layer.

Describe the solution

  1. Identify relations between different flank-scripts features.
  2. Consider identified code as a standalone utility(ies).
  3. Move common implementation to the separated package(s) outside ops.
@jan-goral jan-goral changed the title Make flank-scripts features not depends on each other. Make flank-scripts features not depends on each other Jan 28, 2021
@zuziaka
Copy link
Contributor

zuziaka commented Feb 1, 2021

@jan-gogo / @piotradamczyk5 / @adamfilipow92 can you provide a sdd document for a whole epic?

@zuziaka zuziaka added this to the Sprint 1 milestone Feb 2, 2021
@adamfilipow92 adamfilipow92 self-assigned this Feb 2, 2021
@adamfilipow92 adamfilipow92 mentioned this issue Feb 8, 2021
Merged
1 task
@mergify mergify bot closed this as completed in #1572 Feb 9, 2021
mergify bot pushed a commit that referenced this issue Feb 9, 2021
@adamfilipow92
refactor: Flank scripts features not depends on each other (#1572)
830e8af 
Fixes #1543 

## Test Plan
> How do we know the code works?

The tests should pass. Scripts should work as before.

## Checklist

- [X] Unit tested
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@adamfilipow92 adamfilipow92

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging a pull request may close this issue.

refactor: Flank scripts features not depends on each other Flank/flank
3 participants
@zuziaka @jan-goral @adamfilipow92