Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Data scratch - ip blocks #1746

Closed
jan-goral opened this issue Mar 29, 2021 · 0 comments · Fixed by #1811
Closed

Data scratch - ip blocks #1746

jan-goral opened this issue Mar 29, 2021 · 0 comments · Fixed by #1811

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1727
add abstraction and implementation for the following part of the data layer:

Abstraction

ftl/data/IpBlock.kt

package ftl.data

val fetchIpBLocks: IpBlock.Fetch get() = TODO()

data class IpBlock(
    val block: String,
    val form: String,
    val addedDate: String
) {

    interface Fetch : () -> List<IpBlock>
}

Target

  • ftl/environment/ListIPBlocks.kt

Adapter

ftl/adapter/GoogleIpBlockFetch.kt

@piotradamczyk5 piotradamczyk5 self-assigned this Apr 14, 2021
@mergify mergify bot closed this as completed in #1811 Apr 20, 2021
mergify bot pushed a commit that referenced this issue Apr 20, 2021
Fixes #1746

## Test Plan
> How do we know the code works?

- Code is refactored according to the description in #1746
- command `flank ip-blocks list` runs without any problems

## Checklist

- [x] Unit tested
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants