Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dump shards #1818

Closed
zuziaka opened this issue Apr 19, 2021 · 0 comments · Fixed by #1921
Closed

Dump shards #1818

zuziaka opened this issue Apr 19, 2021 · 0 comments · Fixed by #1921
Assignees

Comments

@zuziaka
Copy link
Contributor

zuziaka commented Apr 19, 2021

No description provided.

@jan-goral jan-goral changed the title Dump shards option Dump shards Apr 22, 2021
@jan-goral jan-goral self-assigned this May 11, 2021
@jan-goral jan-goral linked a pull request May 12, 2021 that will close this issue
3 tasks
mergify bot pushed a commit that referenced this issue May 12, 2021
Related to #1818 

This will allow distinguishing shard calculation and shard dumping as different modules that share the same data scheme.
To meeting SRP on module level.

## Test Plan
> How do we know the code works?

Unit test passes

## Checklist

- [x] Documented
- [x] Unit tested
@jan-goral jan-goral mentioned this issue May 12, 2021
2 tasks
@mergify mergify bot closed this as completed in #1921 May 13, 2021
mergify bot pushed a commit that referenced this issue May 13, 2021
Fixes #1818

~~This PR is blocked by #1920, and will be changed to ready for review after the #1920 merge.~~

## Test Plan
> How do we know the code works?

Unit tests pass.

## Checklist

- [x] Documented
- [x] Unit tested
- [x] #1920 merged
mergify bot pushed a commit that referenced this issue May 14, 2021
Related to #1818

## Test Plan
> How do we know the code works?

Unit tests pass.

## Checklist

- [x] Documented
- [x] Unit tested
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants