Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: IOS GameLoop addition #1325

Merged
merged 7 commits into from
Nov 25, 2020
Merged

feat: IOS GameLoop addition #1325

merged 7 commits into from
Nov 25, 2020

Conversation

zuziaka
Copy link
Contributor

@zuziaka zuziaka commented Nov 17, 2020

This PR adds iOS example project with a game loop.

Scripts for generating IPA file from iOS source code will be added in:
#1345

Support for game loop in Flank will be fully implemented in:
#1341

Test Plan

How do we know the code works?

.

Checklist

  • Documented
  • Unit tested

Bottom note: Flank doesn't support gameloop mode for iOS yet.
Flank requires xctestrun-file which doesn't exist in gameloop mode. #1341

@Sloox Sloox added New Option Used to track PR with new configuration option (useful when updating fladle) iOS labels Nov 17, 2020
@zuziaka
Copy link
Contributor Author

zuziaka commented Nov 17, 2020

@Sloox Added temporary bash scripts:

  • export.sh - will generate IPA
  • ftl.s - will run gcloud command
    You can verify the test project using them.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2020

Timestamp: 2020-11-24 15:44:22
Buildscan url for ubuntu-workflow run 381370388
https://gradle.com/s/idkk3ukjemvkw

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #1325 (d73008a) into master (130e468) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1325      +/-   ##
============================================
- Coverage     77.83%   77.81%   -0.03%     
  Complexity      705      705              
============================================
  Files           244      244              
  Lines          4692     4692              
  Branches        901      901              
============================================
- Hits           3652     3651       -1     
  Misses          550      550              
- Partials        490      491       +1     

@Sloox Sloox changed the title #1280 test app gameloop #1280 test app gameloop file additions Nov 24, 2020
@Sloox Sloox marked this pull request as ready for review November 24, 2020 13:40
- model: iphone11
version: 13.6
orientation: portrait
locale: en_US
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When I try to run this test from Debug.kt Flank returns
Both of following options must be specified [test, xctestrun-file].

Process finished with exit code 2

  • Blank line missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfilipow92 FTL with gameloop mode doesn't need xctestrun-file,
however Flank currently requires it. @Sloox will fix this in next a PR

Copy link
Contributor

@adamfilipow92 adamfilipow92 Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I try to run it on gcloud cli!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfilipow92 this wont work until @jan-gogo applies a fix that will come in #1341 . However #1341 is blocked until other tickets are closed (including this one.)

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on gcloud cli

gcloud alpha firebase test ios run \
 --type game-loop --app FlankGameLoopExample.ipa --scenario-numbers 1 \
 --device model=iphone11,version=13.6

Test pass


┌─────────┬───────────────────────────┬──────────────┐
│ OUTCOME │      TEST_AXIS_VALUE      │ TEST_DETAILS │
├─────────┼───────────────────────────┼──────────────┤
│ Passed  │ iphone11-13.6-en-portrait │ --           │
└─────────┴───────────────────────────┴──────────────┘

zuziaka and others added 7 commits November 24, 2020 15:37
* scripts for archive/export IPA for ios game loop
* scripts for creating test artifacts for iOS Multiple test targets example (test plans)
This reverts commit bc03d64.

Flank scripts for generating game loop artifacts will be added in #1345
@Sloox Sloox changed the title #1280 test app gameloop file additions feat : IOS GameLoop addition Nov 24, 2020
@Flank Flank deleted a comment from mergify bot Nov 24, 2020
@Sloox Sloox changed the title feat : IOS GameLoop addition feat: IOS GameLoop addition Nov 24, 2020
@Sloox Sloox self-requested a review November 24, 2020 19:08
@mergify mergify bot merged commit 3075194 into master Nov 25, 2020
@mergify mergify bot deleted the #1280-test-app-gameloop branch November 25, 2020 05:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
iOS New Option Used to track PR with new configuration option (useful when updating fladle)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants