fix: Publishing Flank snapshot #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
Sloox,
adamfilipow92,
zuziaka,
bootstraponline,
jan-goral and
pawelpasterz
|
Timestamp: 2020-11-24 09:18:32 |
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
=========================================
Coverage 77.87% 77.87%
Complexity 706 706
=========================================
Files 244 244
Lines 4687 4687
Branches 897 897
=========================================
Hits 3650 3650
Misses 549 549
Partials 488 488 |
zuziaka
approved these changes
Nov 20, 2020
piotradamczyk5
force-pushed
the
#1332_fix_publishing_snapshot_jobs
branch
from
a859abe to
cc90a84
Compare
jan-goral
approved these changes
Nov 23, 2020
|
I assume that we cannot test it without merge? |
unfortunately not |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1332
Test Plan
Flank job publish properly snapshot versions
Checklist