Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add fallback when cannot get reference to avoid failing tests on release #1369

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

piotradamczyk5
Copy link
Contributor

Test Plan

How do we know the code works?

When cannot get the branch name from git or HEAD_REF is missing. Tests artifacts are downloaded for master branch

@piotradamczyk5 piotradamczyk5 self-assigned this Dec 1, 2020
@Sloox Sloox self-requested a review December 1, 2020 16:46
@mergify
Copy link

mergify bot commented Dec 1, 2020

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@bootstraponline bootstraponline force-pushed the fallback_for_downloading_artifacts branch from 3bd154a to c0abf7f Compare December 1, 2020 21:41
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

Timestamp: 2020-12-01 21:47:43
Buildscan url for ubuntu-workflow run 394771811
https://gradle.com/s/mqvga6yy7aiiu

@codecov-io
Copy link

Codecov Report

Merging #1369 (c0abf7f) into master (106cb4f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1369   +/-   ##
=========================================
  Coverage     77.81%   77.81%           
  Complexity      705      705           
=========================================
  Files           244      244           
  Lines          4693     4693           
  Branches        901      901           
=========================================
  Hits           3652     3652           
  Misses          550      550           
  Partials        491      491           

@mergify mergify bot merged commit 68a4909 into master Dec 1, 2020
@mergify mergify bot deleted the fallback_for_downloading_artifacts branch December 1, 2020 22:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants