Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Change uploading file output #1429

Merged
merged 12 commits into from
Dec 31, 2020
Merged

feat: Change uploading file output #1429

merged 12 commits into from
Dec 31, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Dec 28, 2020 •
edited by adamfilipow92
Loading

Fixes #1334

Previous uploading Flank output looks like:

Saved 1 shards to android_shards.json
  Uploading android_shards.json .
  Uploading app-debug.apk .
  Uploading app-debug-androidTest.apk .
  1 test / 1 shard

  1 matrix ids created in 0m 3s
  https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir

The new output for file upload looks more like Gcloud output:

  Saved 1 shards to android_shards.json
  Uploading [android_shards.json] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/...
  Uploading [app-debug.apk] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/...
  Uploading [app-debug-androidTest.apk] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/...

  1 test / 1 shard

  1 matrix ids created in 0m 3s
  Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir]

Gcloud file upload output for reference:

Uploading [test_runner/../test_projects/android/apks/app-debug.apk] to Firebase Test Lab...
Uploading [test_runner/../test_projects/android/apks/app-debug-androidTest.apk] to Firebase Test Lab...
Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/test_dir/]

Test Plan

How do we know the code works?

  1. Run Flank
  2. Check output
  3. Output for file upload looks like described above

Checklist

  • Research done
  • Some refactor of output
  • Unit tested
  • Integration tests updated

@piotradamczyk5 piotradamczyk5 force-pushed the #1334_uploading_file_output branch from a9bf787 to 8f63d46 Compare December 28, 2020 16:33
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2020 •
edited
Loading

Integration tests failed, you could see results here

@piotradamczyk5 piotradamczyk5 force-pushed the #1334_uploading_file_output branch from 8f63d46 to af4b29e Compare December 28, 2020 16:43
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2020 •
edited
Loading

Integration tests failed, you could see results here

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2020 •
edited
Loading

Timestamp: 2020-12-31 08:25:40
Buildscan url for ubuntu-workflow run 454175461
https://gradle.com/s/7oibe2xkjrzam

@adamfilipow92 adamfilipow92 self-assigned this Dec 29, 2020
@adamfilipow92 adamfilipow92 marked this pull request as draft December 29, 2020 07:30
@piotradamczyk5 piotradamczyk5 force-pushed the #1334_uploading_file_output branch 2 times, most recently from f082f68 to 7af6e46 Compare December 29, 2020 13:16
@piotradamczyk5 piotradamczyk5 force-pushed the #1334_uploading_file_output branch from 7af6e46 to 23dd3ce Compare December 29, 2020 13:40
@piotradamczyk5 piotradamczyk5 force-pushed the #1334_uploading_file_output branch from 205dddd to dd34e35 Compare December 29, 2020 17:14
@adamfilipow92
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2020 •
edited
Loading

Integration tests failed ❌
Build scan https://gradle.com/s/cztzvgnxnwwui
Workflow run https://github.com/Flank/flank/actions/runs/452641114

@adamfilipow92 adamfilipow92 marked this pull request as ready for review December 30, 2020 13:20
@piotradamczyk5
Copy link
Contributor Author

piotradamczyk5 commented Dec 30, 2020 •
edited
Loading

Integration tests failed ❌
Build scan https://gradle.com/s/cztzvgnxnwwui
Workflow run https://github.com/Flank/flank/actions/runs/452641114

Quota exceed 😞

@piotradamczyk5 piotradamczyk5 requested a review from Sloox December 30, 2020 13:21
pawelpasterz
pawelpasterz suggested changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run locally and have one test failed (except the other two failed due to quota exceeded.... 😓 )
Of course, I forgot to use --scan flag so the only thing I can share is the gist from output https://gist.github.com/pawelpasterz/52b4ce341265e3b982607992b67a3dc3

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2020 •
edited
Loading

Integration tests failed ❌
Build scan https://gradle.com/s/xyop3p7tzbovo
Workflow run https://github.com/Flank/flank/actions/runs/454186399

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2020 •
edited
Loading

Integration tests succeed ✅
Build scan https://gradle.com/s/poqtr24gb3s36
Workflow run https://github.com/Flank/flank/actions/runs/454186399

@mergify mergify bot merged commit da55e8d into master Dec 31, 2020
@mergify mergify bot deleted the #1334_uploading_file_output branch December 31, 2020 09:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@jan-goral jan-goral Awaiting requested review from jan-goral

@zuziaka zuziaka Awaiting requested review from zuziaka

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check and improve uploading file console output
4 participants
@piotradamczyk5 @adamfilipow92 @Sloox @pawelpasterz